Rewrite the action as a javascript action #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnalh
force-pushed
the
gabe/action-rewrite
branch
2 times, most recently
from
d1aaa83 to
184916f
Compare
gnalh
force-pushed
the
gabe/action-rewrite
branch
from
184916f to
8a16313
Compare
gnalh
force-pushed
the
gabe/action-rewrite
branch
from
48c11be to
a66856f
Compare
gnalh
changed the title
gnalh
commented
Apr 16, 2025
Comment on lines
+50
to
+52
| github-token: | ||
| description: The GitHub token used to create an authenticated client | ||
| default: ${{ github.token }} |
There was a problem hiding this comment.
This is automatic, but also necessary since it can't be extracted below.
gnalh
force-pushed
the
gabe/action-rewrite
branch
from
a66856f to
ecd18fe
Compare
gnalh
force-pushed
the
gabe/action-rewrite
branch
from
ecd18fe to
977411a
Compare
gnalh
commented
Apr 16, 2025
| const token = core.getInput("github-token"); | ||
| if (!token) { | ||
| core.error( | ||
| "GITHUB_TOKEN is not set. Please ensure the job has the necessary permissions. Attempting to run unauthenticated.", |
There was a problem hiding this comment.
grabbing the token is automatic (unless overriden). We can work without it, we just hit lower rate limits.
cmillar-trunk
approved these changes
Apr 16, 2025
gnalh
added a commit
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us much more flexibility and ease of testing.